Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

xterm #212

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

xterm #212

wants to merge 1 commit into from

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 24, 2021

replaces term.js with xterm

fixes #211
fixes #210

Tests:

  • Open terminal
  • Resize terminal
  • Move terminal to dock
  • Resize dock
  • Type in terminal
  • Test different options

@the-j0k3r the-j0k3r added the enhancement ⚙️ New feature or request label Mar 25, 2021
@the-j0k3r
Copy link
Member

the-j0k3r commented Mar 25, 2021

Tests

  • Open terminal
  1. Open terminal via taskbar
  2. Terminal opens without signs of life
  3. Toggle terminal via shortcut
  4. Terminal opens and closes until it gets stuck and wont be closed
  • Resize terminal
    Terminals cant be resized

  • Move terminal to dock
    Terminal cant be dragged

generic

generic

and aborted tests.

Atom    : 1.55.0
Electron: 6.1.12
Chrome  : 76.0.3809.146
Node    : 12.4.0
apm  2.5.2
npm  6.14.8
node 12.4.0 x64
atom 1.55.0
python 2.7.17
git 2.30.1.windows.1
visual studio

Windows 10 Workstation 1909

@the-j0k3r
Copy link
Member

Had a couple of minutes to retest this under Ubuntu + Atom 1.57.0, similar result as initial test.

It may be worth noting that the lockfile version is being modified on install and this has a considerable diff.

See https://gist.github.com/the-j0k3r/f8291565d36b37cef33d32ef1b5961ff/revisions

No sure how that would affect the installation or if it is the cause for issues.

@UziTech with 💓

@UziTech
Copy link
Member Author

UziTech commented Jun 13, 2021

I think this just needs to use the xterm-fit-addon to be able to resize correctly. I will have more time in about a week to try to finish this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement ⚙️ New feature or request
Development

Successfully merging this pull request may close these issues.

Use xterm in terminus instead of term.js [BR] Unicode characters not rendering correctly.
2 participants